Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder for distance_feature to QueryBuilders #47846

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

cbuescher
Copy link
Member

The QueryBuilders convenience class is currently missing a shortcut to construct
a DistanceFeatureQueryBuilder, which is added here.

Closes #47767

The QueryBuilders convenience class is currently missing a shortcut to construct
a DistanceFeatureQueryBuilder, which is added here.

Closes elastic#47767
@cbuescher cbuescher added >enhancement :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.5.0 labels Oct 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I also noticed we don't have a function for the other feature query rank_feature. We could add it here too, since it's not a big change?

@cbuescher
Copy link
Member Author

we don't have a function for the other feature query rank_feature. We could add it here too

@jtibshirani good call, I briefly looked into this and found that this query already has its own helper class RankFeatureQueryBuilders. Furhtermore both the query builder and the facade class live in the mapper-extras module, so they are not accessible from QueryBuilders. This is a downside of our modularization I think, but I don't see a quick way of resolving this. I will merge this as is if you don't have any other ideas and agree.

@jtibshirani
Copy link
Contributor

jtibshirani commented Oct 11, 2019

Thanks for looking into that @cbuescher, I hadn't realized it had its own factory class because it's a plugin. I agree it makes sense to merge this as-is.

@cbuescher cbuescher merged commit 1966b3b into elastic:master Oct 11, 2019
cbuescher pushed a commit that referenced this pull request Oct 11, 2019
The QueryBuilders convenience class is currently missing a shortcut to construct
a DistanceFeatureQueryBuilder, which is added here.

Closes #47767
howardhuanghua pushed a commit to TencentCloudES/elasticsearch that referenced this pull request Oct 14, 2019
The QueryBuilders convenience class is currently missing a shortcut to construct
a DistanceFeatureQueryBuilder, which is added here.

Closes elastic#47767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryBuilders is missing builder for distance_feature
4 participants