[ML][Transforms] signal listener early on task _stop failure #47954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
changed the title
benwtrent
deleted the
feature/ml-transforms-return-to-listner-on-failure
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 14, 2019
benwtrent
added a commit
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is some failure in the
stopcall, we don't handle it. Consequently, the listener could just spin forever waiting for a task to be removed when it never will be.This adds some logic to signal back to the listener if some node failures or task failures occurred.
This is particularly troublesome on tests where a
_stopfails aswaitForPersistentTasksConditionis only ever fired on cluster state updates, and if no updates occur, it will simply sit there indefinitely.