Introduce system JVM options #48252
Merged
Introduce system JVM options #48252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves JVM options that we are setting on behalf of the user that we do not expect them to fiddle with out of the jvm.options configuration file and into the JVM options parser. In this way, we discourage fiddling with these settings, but more importantly, we ensure that as we evolve or add to these settings that a user would pick these pick instead of being left behind if they have a modified jvm.options file and do not pick any new that come with the distribution.
jasontedor
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
pickypg
approved these changes
Oct 18, 2019
...bution/tools/launchers/src/main/java/org/elasticsearch/tools/launchers/JvmOptionsParser.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
pugnascotia
reviewed
Oct 19, 2019
| @@ -90,8 +91,10 @@ public void accept(final int lineNumber, final String line) { | |||
| final List<String> substitutedJvmOptions = | |||
| substitutePlaceholders(jvmOptions, Map.of("ES_TMPDIR", System.getenv("ES_TMPDIR"))); | |||
| final List<String> ergonomicJvmOptions = JvmErgonomics.choose(substitutedJvmOptions); | |||
| substitutedJvmOptions.addAll(ergonomicJvmOptions); | |||
| final String spaceDelimitedJvmOptions = spaceDelimitJvmOptions(substitutedJvmOptions); | |||
| final List<String> finalJvmOptions = Stream.concat( | |||
There was a problem hiding this comment.
I wondered if this would be any better using a plain old list:
final List<String> finalJvmOptions = new ArrayList<>(SystemJvmOptions.systemJvmOptions());
finalJvmOptions.addAll(substitutedJvmOptions);
finalJvmOptions.addAll(ergonomicJvmOptions);
pugnascotia
reviewed
Oct 19, 2019
|
@elasticmachine update branch |
rjernst
approved these changes
Oct 21, 2019
| -Dlog4j.shutdownHookEnabled=false | ||
| -Dlog4j2.disable.jmx=true | ||
|
|
||
| ## JVM temporary directory | ||
| -Djava.io.tmpdir=${ES_TMPDIR} |
There was a problem hiding this comment.
Since the environment variable ES_TMPDIR is how users set the tempdir, shouldn't this jvm option be included in the system options?
|
|
||
| final class SystemJvmOptions { | ||
|
|
||
| static List<String> systemJvmOptions() { |
There was a problem hiding this comment.
nit: Why a separate class and not just a static final list in JvmOptionsParser?
|
@elasticmachine run elasticsearch-ci/2 |
* elastic/master: [Docs] Fix opType options in IndexRequest API example. (elastic#48290) Simplify Shard Snapshot Upload Code (elastic#48155) Mute ClassificationIT tests (elastic#48338) Reenable azure repository tests and remove some randomization in http servers (elastic#48283) Use an env var for the classpath of jar hell task (elastic#48240) Refactor FIPS BootstrapChecks to simple checks (elastic#47499) Add "format" to "range" queries resulted from optimizing a logical AND (elastic#48073) [DOCS][Transform] document limitation regarding rolling upgrade with 7.2, 7.3 (elastic#48118) Fail with a better error when if there are no ingest nodes (elastic#48272) Fix executing enrich policies stats (elastic#48132) Use MultiFileTransfer in CCR remote recovery (elastic#44514) Make BytesReference an interface (elastic#48171) Also validate source index at put enrich policy time. (elastic#48254) Add 'javadoc' task to lifecycle check tasks (elastic#48214) Remove option to enable direct buffer pooling (elastic#47956) [DOCS] Add 'Selecting gateway and seed nodes' section to CCS docs (elastic#48297) Add Enrich Origin (elastic#48098) fix incorrect comparison (elastic#48208)
jasontedor
added a commit
that referenced
this pull request
Oct 28, 2019
This commit moves JVM options that we are setting on behalf of the user that we do not expect them to fiddle with out of the jvm.options configuration file and into the JVM options parser. In this way, we discourage fiddling with these settings, but more importantly, we ensure that as we evolve or add to these settings that a user would pick these pick instead of being left behind if they have a modified jvm.options file and do not pick any new that come with the distribution.
jasontedor
added a commit
that referenced
this pull request
Oct 28, 2019
This commit moves JVM options that we are setting on behalf of the user that we do not expect them to fiddle with out of the jvm.options configuration file and into the JVM options parser. In this way, we discourage fiddling with these settings, but more importantly, we ensure that as we evolve or add to these settings that a user would pick these pick instead of being left behind if they have a modified jvm.options file and do not pick any new that come with the distribution.
danielmitterdorfer
added a commit
to danielmitterdorfer/rally-teams
that referenced
this pull request
Mar 13, 2020
With this commit we remove all JVM options that are considered "system JVM options" which are already hardcoded in Elasticsearch and set by default. Relates elastic/elasticsearch#48252
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this pull request
Mar 19, 2020
With this commit we remove all JVM options that are considered "system JVM options" which are already hardcoded in Elasticsearch and set by default. Relates elastic/elasticsearch#48252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves JVM options that we are setting on behalf of the user that we do not expect them to fiddle with out of the jvm.options configuration file and into the JVM options parser. In this way, we discourage fiddling with these settings, but more importantly, we ensure that as we evolve or add to these settings that a user would pick these pick instead of being left behind if they have a modified jvm.options file and do not pick any new that come with the distribution.
Closes #48222