Bug #42997 #48270
Open
Bug #42997 #48270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and handling it in the same way it is handled for parentIdFieldMapper
…and handling it in the same way it is handled for parentIdFieldMapper
jimczi
requested changes
Oct 22, 2019
There was a problem hiding this comment.
Thanks @Suchita94, I left two comments. Can you also update the title to be more descriptive ? Something like: "fixed children aggregation with unmapped fields".
| @@ -112,16 +112,21 @@ protected void innerWriteTo(StreamOutput out) throws IOException { | |||
|
|
|||
| private void joinFieldResolveConfig(QueryShardContext queryShardContext, ValuesSourceConfig<WithOrdinals> config) { | |||
| ParentJoinFieldMapper parentJoinFieldMapper = ParentJoinFieldMapper.getMapper(queryShardContext.getMapperService()); | |||
| if (parentJoinFieldMapper != null) { | |||
There was a problem hiding this comment.
Should it be:
Suggested change
| if (parentJoinFieldMapper != null) { | |
| if (parentJoinFieldMapper == null) { |
?
| if (parentJoinFieldMapper != null) { | ||
| config.unmapped(true); | ||
| return; | ||
| } | ||
| ParentIdFieldMapper parentIdFieldMapper = parentJoinFieldMapper.getParentIdFieldMapper(childType, false); | ||
| if (parentIdFieldMapper != null) { |
There was a problem hiding this comment.
Same here ?
Suggested change
| if (parentIdFieldMapper != null) { | |
| if (parentIdFieldMapper == null) { |
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
rjernst
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Looks like we got this in #57089. Sorry for letting this languish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added null check and modified test cases