Update README.textile #48370

nithasha-samad · 2019-10-23T06:30:26Z

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
If submitting code, have you built your formula locally prior to submission with gradle check?
If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
If submitting code, have you checked that your submission is for an OS and architecture that we support?
If you are submitting this code for a class then read our policy for that.

elasticmachine · 2019-10-23T08:31:28Z

Pinging @elastic/es-docs (>docs)

elasticmachine · 2019-10-23T12:30:41Z

Pinging @elastic/es-core-infra (:Core/Infra/Build)

jrodewig · 2019-10-23T12:31:55Z

README.textile

@@ -207,7 +207,7 @@ In order to create a distribution, simply run the @./gradlew assemble@ command i

 The distribution for each project will be created under the @build/distributions@ directory in that project.

-See the "TESTING":TESTING.asciidoc file for more information about running the Elasticsearch test suite.
+See "TESTING": TESTING.asciidoc file for more information about running the Elasticsearch test suite.


I believe this sentence reads more clearly with the.

Suggested change

See "TESTING": TESTING.asciidoc file for more information about running the Elasticsearch test suite.

See the "TESTING": TESTING.asciidoc file for more information about running the Elasticsearch test suite.

jrodewig · 2019-10-23T12:32:22Z

README.textile


-In order to play with the distributed nature of Elasticsearch, simply bring more nodes up and shut down nodes. The system will continue to serve requests (make sure you use the correct http port) with the latest data indexed.
+In order to play with the distributed nature of Elasticsearch, simply bring more nodes up and shut down nodes. The system will continue to serve requests (make sure you use the correct Http port) with the latest data indexed.


I don't believe the capitalization is needed here.

Suggested change

In order to play with the distributed nature of Elasticsearch, simply bring more nodes up and shut down nodes. The system will continue to serve requests (make sure you use the correct Http port) with the latest data indexed.

In order to play with the distributed nature of Elasticsearch, simply bring more nodes up and shut down nodes. The system will continue to serve requests (make sure you use the correct http port) with the latest data indexed.

jrodewig · 2019-10-23T12:33:19Z

README.textile

@@ -185,15 +185,15 @@ curl -XGET 'http://localhost:9200/_search?pretty=true' -H 'Content-Type: applica
 }'
 </pre>

-{One liner teaser}: And the cool part about that? You can easily search on multiple twitter users (indices), with different boost levels per user (index), making social search so much simpler (results from my friends rank higher than results from friends of my friends).
+{One liner teaser}: And the cool part about that? You can easily search on multiple twitter users (indices), with different boost levels per user (index), making the social search so much simpler (results from my friends rank higher than results from friends of my friends).


Reads better without the here.

Suggested change

{One liner teaser}: And the cool part about that? You can easily search on multiple twitter users (indices), with different boost levels per user (index), making the social search so much simpler (results from my friends rank higher than results from friends of my friends).

{One liner teaser}: And the cool part about that? You can easily search on multiple twitter users (indices), with different boost levels per user (index), making social search so much simpler (results from my friends rank higher than results from friends of my friends).

jrodewig · 2019-10-23T12:34:19Z

README.textile


-Another way to define our simple twitter system is to have a different index per user (note, though that each index has an overhead). Here is the indexing curl's in this case:
+Another way to define our simple twitter system is to have a different index per user (note, though that each index has an overhead). Here is the indexing curl in this case:


There are multiple curl requests here.

Suggested change

Another way to define our simple twitter system is to have a different index per user (note, though that each index has an overhead). Here is the indexing curl in this case:

Another way to define our simple twitter system is to have a different index per user (note, though that each index has an overhead). Here is the indexing curl's in this case:

jrodewig · 2019-10-23T12:34:47Z

README.textile

@@ -122,18 +122,18 @@ curl -XGET 'http://localhost:9200/twitter/_search?pretty=true' -H 'Content-Type:
 }'
 </pre>

-There are many more options to perform search, after all, it's a search product no? All the familiar Lucene queries are available through the JSON query language, or through the query parser.
+There are many more options to perform the search, after all, it's a search product no? All the familiar Lucene queries are available through the JSON query language, or through the query parser.


the is unneeded.

Suggested change

There are many more options to perform the search, after all, it's a search product no? All the familiar Lucene queries are available through the JSON query language, or through the query parser.

There are many more options to perform search, after all, it's a search product no? All the familiar Lucene queries are available through the JSON query language, or through the query parser.

jrodewig · 2019-10-23T12:35:36Z

README.textile

@@ -109,7 +109,7 @@ curl -XGET 'http://localhost:9200/twitter/_search?pretty=true' -H 'Content-Type:
 }'
 </pre>

-We can also do range search (the @post_date@ was automatically identified as date)
+We can also do range search (the @post_date@ was automatically identified as to date)


Suggested change

We can also do range search (the @post_date@ was automatically identified as to date)

We can also do range search (the @post_date@ was automatically identified as a date)

jrodewig · 2019-10-23T12:35:50Z

README.textile

@@ -39,7 +39,7 @@ You need to have a recent version of Java installed. See the "Setup":http://www.
 h3. Installation

 * "Download":https://www.elastic.co/downloads/elasticsearch and unzip the Elasticsearch official distribution.
-* Run @bin/elasticsearch@ on unix, or @bin\elasticsearch.bat@ on windows.
+* Run @bin/elasticsearch@ on Unix, or @bin\elasticsearch.bat@ on windows.


Suggested change

* Run @bin/elasticsearch@ on Unix, or @bin\elasticsearch.bat@ on windows.

* Run @bin/elasticsearch@ on Unix, or @bin\elasticsearch.bat@ on Windows.

jrodewig · 2019-10-23T12:36:18Z

README.textile

 * Built on top of Lucene
 ** Each shard is a fully functional Lucene index
-** All the power of Lucene easily exposed through simple configuration / plugins.
+** All the power of Lucene easily exposed through simple configuration/plugins.


Suggested change

** All the power of Lucene easily exposed through simple configuration/plugins.

** All the power of Lucene easily exposed through simple configuration and plugins.

jrodewig · 2019-10-23T12:36:41Z

README.textile

@@ -21,10 +21,10 @@ Elasticsearch is a distributed RESTful search engine built for the cloud. Featur
 ** No need for upfront schema definition.
 ** Schema can be defined for customization of the indexing process.
 * Reliable, Asynchronous Write Behind for long term persistency.
-* (Near) Real Time Search.
+* (Near) Real-Time Search.


Suggested change

* (Near) Real-Time Search.

* (Near) real-time search.

jrodewig · 2019-10-23T12:36:50Z

README.textile

@@ -10,7 +10,7 @@ Elasticsearch is a distributed RESTful search engine built for the cloud. Featur
 ** Each index is fully sharded with a configurable number of shards.
 ** Each shard can have one or more replicas.
 ** Read / Search operations performed on any of the replica shards.
-* Multi Tenant.
+* Multi-Tenant.


Suggested change

* Multi-Tenant.

* Multi-tenant.

jrodewig

Thanks @nithasha-samad. Two things:

I left a few comments and suggestions for you to address.
Could you sign our contributor license agreement? This is necessary before we'll be able to merge your changes.

After you address the feedback and sign the CLA, I can help merge these changes. Thanks again for your contribution.

jrodewig · 2019-12-10T20:26:36Z

Closing as the CLA is not signed and feedback has not been addressed.

Update README.textile

bed7062

pgomulka added the >docs General docs changes label Oct 23, 2019

jrodewig added the :Delivery/Build Build or test infrastructure label Oct 23, 2019

jrodewig reviewed Oct 23, 2019

View reviewed changes

jrodewig suggested changes Oct 23, 2019

View reviewed changes

jrodewig added Awaiting CLA feedback_needed labels Oct 23, 2019

jrodewig closed this Dec 10, 2019

mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README.textile #48370

Update README.textile #48370

nithasha-samad commented Oct 23, 2019

elasticmachine commented Oct 23, 2019

elasticmachine commented Oct 23, 2019

jrodewig Oct 23, 2019 •

edited

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig Oct 23, 2019

jrodewig left a comment

jrodewig commented Dec 10, 2019

	See "TESTING": TESTING.asciidoc file for more information about running the Elasticsearch test suite.
	See the "TESTING": TESTING.asciidoc file for more information about running the Elasticsearch test suite.


		In order to play with the distributed nature of Elasticsearch, simply bring more nodes up and shut down nodes. The system will continue to serve requests (make sure you use the correct http port) with the latest data indexed.
		In order to play with the distributed nature of Elasticsearch, simply bring more nodes up and shut down nodes. The system will continue to serve requests (make sure you use the correct Http port) with the latest data indexed.

	{One liner teaser}: And the cool part about that? You can easily search on multiple twitter users (indices), with different boost levels per user (index), making the social search so much simpler (results from my friends rank higher than results from friends of my friends).
	{One liner teaser}: And the cool part about that? You can easily search on multiple twitter users (indices), with different boost levels per user (index), making social search so much simpler (results from my friends rank higher than results from friends of my friends).


		Another way to define our simple twitter system is to have a different index per user (note, though that each index has an overhead). Here is the indexing curl's in this case:
		Another way to define our simple twitter system is to have a different index per user (note, though that each index has an overhead). Here is the indexing curl in this case:

	There are many more options to perform the search, after all, it's a search product no? All the familiar Lucene queries are available through the JSON query language, or through the query parser.
	There are many more options to perform search, after all, it's a search product no? All the familiar Lucene queries are available through the JSON query language, or through the query parser.

	We can also do range search (the @post_date@ was automatically identified as to date)
	We can also do range search (the @post_date@ was automatically identified as a date)

	* Run @bin/elasticsearch@ on Unix, or @bin\elasticsearch.bat@ on windows.
	* Run @bin/elasticsearch@ on Unix, or @bin\elasticsearch.bat@ on Windows.

	** All the power of Lucene easily exposed through simple configuration/plugins.
	** All the power of Lucene easily exposed through simple configuration and plugins.

Update README.textile #48370

Update README.textile #48370

Conversation

nithasha-samad commented Oct 23, 2019

elasticmachine commented Oct 23, 2019

elasticmachine commented Oct 23, 2019

jrodewig Oct 23, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrodewig left a comment

Choose a reason for hiding this comment

jrodewig commented Dec 10, 2019

jrodewig Oct 23, 2019 •

edited