Support search_type in Rank Evaluation API
#48542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for the `search_type` request parameter to the Ranking Evaluation API since this parameter can impact the ranking and the metric score and should be choosen in the same way when evaluating the search as later in the real search. Closes elastic#48503
cbuescher
added
>enhancement
:Search Relevance/Ranking
|
Pinging @elastic/es-search (:Search/Ranking) |
jimczi
requested changes
Oct 29, 2019
| @@ -39,12 +39,9 @@ | |||
| import org.elasticsearch.tasks.Task; | |||
There was a problem hiding this comment.
This change doesn't seem to be for this pr ?
There was a problem hiding this comment.
Yes, I pulled this out to #48523 and didn't delete it here.
| * The a string representation search type to execute, defaults to {@link SearchType#DEFAULT}. Can be one of | ||
| * "dfs_query_then_fetch"/"dfsQueryThenFetch", "dfs_query_and_fetch"/"dfsQueryAndFetch", "query_then_fetch"/"queryThenFetch", and | ||
| * "query_and_fetch"/"queryAndFetch". | ||
| */ |
There was a problem hiding this comment.
Is this really needed ? It should be enough to use the SearchType enum ? If not, then the comment should be changed since the types are restricted to dfs_query_then_fetch and query_then_fetch.
|
@jimczi thanks for the review, I pushed some changes that should adress your comments. |
|
@elasticmachine update branch |
jimczi
reviewed
Oct 29, 2019
| // */ | ||
| // public void searchType(String searchType) { | ||
| // searchType(SearchType.fromString(searchType)); | ||
| // } |
|
@elasticmachine run elasticsearch-ci/2 |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Oct 29, 2019
Adding support for the `search_type` request parameter to the Ranking Evaluation API since this parameter can impact the ranking and the metric score and should be choosen in the same way when evaluating the search as later in the real search. Closes elastic#48503
cbuescher
pushed a commit
that referenced
this pull request
Oct 29, 2019
Adding support for the `search_type` request parameter to the Ranking Evaluation API since this parameter can impact the ranking and the metric score and should be choosen in the same way when evaluating the search as later in the real search. Closes #48503
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the
search_typerequest parameter to the Ranking EvaluationAPI since this parameter can impact the ranking and the metric score and should
be choosen in the same way when evaluating the search as later in the real
search.
Closes #48503