Greedily advance safe commit on new global checkpoint #48559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Distributed/Engine
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
dnhatn
changed the title
ywelsch
reviewed
Oct 28, 2019
server/src/main/java/org/elasticsearch/index/engine/CombinedDeletionPolicy.java
Outdated
Show resolved
Hide resolved
henningandersen
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
LGTM. Thanks @dnhatn
I left a very small optional comment only.
server/src/main/java/org/elasticsearch/index/engine/CombinedDeletionPolicy.java
Outdated
Show resolved
Hide resolved
|
Thanks @ywelsch @henningandersen. |
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
Today we won't advance the safe commit on a new global checkpoint unless the last commit can become safe. This is not great if we have more than two commits as we can have a new safe commit earlier. Closes #4853
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
Today we won't advance the safe commit on a new global checkpoint unless the last commit can become safe. This is not great if we have more than two commits as we can have a new safe commit earlier. Closes #4853
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
Today we won't advance the safe commit on a new global checkpoint unless the last commit can become safe. This is not great if we have more than two commits as we can have a new safe commit earlier. Closes #4853
dnhatn
added a commit
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we won't advance the safe commit on a new global checkpoint unless the last commit can become safe. This is not great if we have more than two commits as we can have a new safe commit sooner.
Closes #48532