Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when pausing index #48915

Merged
merged 4 commits into from
Nov 11, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 8, 2019

Throw an appropriate error message when the follower index is not found or is a regular index.

See: https://discuss.elastic.co/t/no-shard-follow-tasks-when-pausing-following-on-follower-index/207074/3

@dnhatn dnhatn added >enhancement :Distributed/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.6.0 labels Nov 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CCR)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvg
Copy link
Member

(The IndexFollowingIT#testUnfollowNonExistingIndex() does also need to be adjusted)

@dnhatn
Copy link
Member Author

dnhatn commented Nov 11, 2019

Thanks @martijnvg.

@dnhatn dnhatn merged commit ae0d0ca into elastic:master Nov 11, 2019
@dnhatn dnhatn deleted the improve-error-message-pause-ccr branch November 11, 2019 13:57
debadair pushed a commit to debadair/elasticsearch that referenced this pull request Nov 13, 2019
Throw an appropriate error message when the follower index is not found 
or is a regular index.
dnhatn added a commit that referenced this pull request Nov 20, 2019
Throw an appropriate error message when the follower index is not found
or is a regular index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features >enhancement v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants