Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify link of install Elasticsearch #48943

Closed

Conversation

y-vectorfield
Copy link

Link of install.asciidoc is not correct. I modified this link.

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the version of this page on master that is online, the link works for me and is pointing to https://www.elastic.co/guide/en/elasticsearch/reference/master/install-elasticsearch.html.
Would you mind sharing what you are seeing? I think the link is correct as is.

@alpar-t alpar-t added the :Docs label Nov 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (:Docs)

@cbuescher cbuescher added >docs General docs changes and removed :Docs labels Nov 12, 2019
@jrodewig jrodewig added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Nov 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@y-vectorfield
Copy link
Author

@cbuescher
Thank you very much for your comment. I'm sorry, this modify arose from my misunderstanding.
I am going to close this pull request.

By the way, I have a question. Why do you use {es} attribution of asciidoc in reference/setup/install.asciidoc? If it is necessary to modify, I am going to submit a pull request.

@cbuescher
Copy link
Member

Why do you use {es} attribution of asciidoc in reference/setup/install.asciidoc

Thanks for asking, to be honest I don't know but @jrodewig might have an answer to that. I don't think it needs changing though.

@y-vectorfield y-vectorfield deleted the modify-link-of-document branch November 12, 2019 15:21
@jrodewig
Copy link
Contributor

jrodewig commented Nov 12, 2019

Hi @y-vectorfield!

The {es} attribute expands to Elasticsearch in our final HTML output. We maintain a similar list of common and branded terms here:
https://github.com/elastic/docs/blob/master/shared/attributes.asciidoc#L88

We use attributes to stay DRY and consistent if we change a product name in the future. Updating the expanded term in a single place makes that much easier. It also reduces the likelihood of typos and misspellings.

@y-vectorfield
Copy link
Author

Hello, @jrodewig ,
Thank you very much for your comments and useful information.

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes feedback_needed Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants