Add telemetry for flattened fields. #48972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
jtibshirani
force-pushed
the
flattened-field-telemetry
branch
from
9dece87
to
66e75e5
Compare
Currently we just record the number of flattened fields defined in the mappings.
jtibshirani
force-pushed
the
flattened-field-telemetry
branch
from
66e75e5
to
0724ca6
Compare
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
mayya-sharipova
approved these changes
Nov 13, 2019
|
|
||
| public FlattenedFeatureSetUsage(StreamInput input) throws IOException { | ||
| super(input); | ||
| this.fieldCount = input.getVersion().onOrAfter(Version.V_8_0_0) ? input.readInt() : 0; |
There was a problem hiding this comment.
I assume for 7.x the version would be changed to V_7_6_0 here and in writeTo.
There was a problem hiding this comment.
Right, that was my plan. Then I'll make an update on master to change to V_7_6_0 as well.
jtibshirani
added a commit
that referenced
this pull request
Nov 18, 2019
jtibshirani
added a commit
that referenced
this pull request
Nov 18, 2019
Follow-up to #48972, which was also backported to 7.6.
jpountz
reviewed
Jan 10, 2020
| @@ -0,0 +1,41 @@ | |||
| setup: | |||
| - skip: | |||
| version: " - 7.99.99" | |||
There was a problem hiding this comment.
@jtibshirani Should this one be 7.5.99 now?
There was a problem hiding this comment.
Oops, thanks @jpountz, I missed this when updating the serialization version.
jtibshirani
added a commit
that referenced
this pull request
Jan 10, 2020
It can be lowered to 7.5.99 now that the functionality was backported in #48972.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
It can be lowered to 7.5.99 now that the functionality was backported in elastic#48972.
This was referenced Feb 3, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#48972 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 23, 2020
Relates: #4341, elastic/elasticsearch#48972 (cherry picked from commit 31ecd9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we just record the number of flattened fields defined in the mappings.