Introduce variable encoding to EdgeTreeReader #49349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
iverase
approved these changes
Nov 22, 2019
server/src/main/java/org/elasticsearch/common/geo/EdgeTreeReader.java
Outdated
Show resolved
Hide resolved
talevy
added a commit
that referenced
this pull request
Nov 22, 2019
This PR modifies the EdgeTree in the [geoshape-doc-values initiative](#37206) to encode the points in a variable fashion. It also adds caching to reduce the number of new Edge objects created and reduce the number of deserializations needed when an aggregation queries the shape multiple times like it does in geogrid aggregations The modifications include: - delta encoding of edge's coordinates using delta-encoding based on maxX, maxY of the Extent - remove Edge object construction and in-line all the deserialization of the edge contents within each method after these changes, two aspects of the GeometryTree feel like TODOs - reduce serialized size of Extent and simplify the `checkExtent` logic - compress Point2D tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the EdgeTree in the geoshape-doc-values initiative to encode the
points in a variable fashion. It also adds caching to reduce the number of new Edge
objects created and reduce the number of deserializations needed when an aggregation
queries the shape multiple times like it does in geogrid aggregations
The modifications include:
after these changes, two aspects of the GeometryTree feel like TODOs
checkExtentlogic