Replace required pipeline with final pipeline #49470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the required pipeline functionality by changing it so that default/request pipelines can also be executed, but the required pipeline is always executed last. This gives users the flexibility to execute their own indexing pipelines, but also ensure that any required pipelines are also executed. Since such pipelines are executed last, we change the name of required pipelines to final pipelines.
jasontedor
added
>enhancement
blocker
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
martijnvg
reviewed
Nov 22, 2019
|
@elasticmachine update branch |
jasontedor
added a commit
that referenced
this pull request
Nov 22, 2019
This commit enhances the required pipeline functionality by changing it so that default/request pipelines can also be executed, but the required pipeline is always executed last. This gives users the flexibility to execute their own indexing pipelines, but also ensure that any required pipelines are also executed. Since such pipelines are executed last, we change the name of required pipelines to final pipelines.
jasontedor
added a commit
that referenced
this pull request
Nov 22, 2019
This commit enhances the required pipeline functionality by changing it so that default/request pipelines can also be executed, but the required pipeline is always executed last. This gives users the flexibility to execute their own indexing pipelines, but also ensure that any required pipelines are also executed. Since such pipelines are executed last, we change the name of required pipelines to final pipelines.
This was referenced Feb 3, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 13, 2020
Relates: #4341, elastic/elasticsearch#49470 This commit adds final pipeline to index settings and deprecates required pipeline.
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#49470 This commit adds final pipeline to index settings and deprecates required pipeline.
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#49470 This commit adds final pipeline to index settings and deprecates required pipeline.
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#49470 This commit adds final pipeline to index settings and deprecates required pipeline. Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 23, 2020
Relates: #4341, elastic/elasticsearch#49470 This commit adds final pipeline to index settings and deprecates required pipeline. (cherry picked from commit bfd4221)
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Dec 19, 2022
It's about *final* pipelines (not *required* pipelines) -- see elastic#46847 and elastic#49470 for the history here, 'required' pipelines were renamed to 'final' pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the required pipeline functionality by changing it so that default/request pipelines can also be executed, but the required pipeline is always executed last. This gives users the flexibility to execute their own indexing pipelines, but also ensure that any required pipelines are also executed. Since such pipelines are executed last, we change the name of required pipelines to final pipelines.
Closes #49247