Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make only a part of stop() method a critical section. #49756

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Make only a part of stop() method a critical section. #49756

merged 1 commit into from
Dec 3, 2019

Conversation

przemekwitek
Copy link
Contributor

PR #49282 made the AnalyticsProcessManager.stop method synchronized to prevent swallowing stop signal.
This PR relaxes the synchronization a bit aiming at:

  1. Keeping the guarantee that stop signal will not be swallowed (i.e. if stop is called soon after start, the start action will not execute)
  2. fixing a possible deadlock (which may be manifesting as timeout on CI)

Relates #49680

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

dimitris-athanasiou
dimitris-athanasiou approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit ada3ca6 into elastic:master Dec 3, 2019
@przemekwitek przemekwitek deleted the fix_test_stop_and_restart_timeout branch December 3, 2019 07:19
@przemekwitek przemekwitek mentioned this pull request Dec 3, 2019
Merged
przemekwitek added a commit that referenced this pull request Dec 3, 2019
@przemekwitek
Make only a part of stop() method a critical section. (#49756) (#49788
1d8e3d6 
)
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@przemekwitek @SivagurunathanV
Make only a part of stop() method a critical section. (elastic#49756)
4a126ab
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
>bug :ml Machine learning v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@przemekwitek @elasticmachine @dimitris-athanasiou @jakelandis