Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dependent settings values to be validated #49942

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Enable dependent settings values to be validated #49942

merged 2 commits into from
Dec 9, 2019

Commits on Dec 6, 2019

  1. Enable dependent settings values to be validated 

    Today settings can declare dependencies on another setting. This
declaration is implemented so that if the declared setting is not set
when the declaring setting is, settings validation fails. Yet, in some
cases we want not only that the setting is set, but that it also has a
specific value. For example, with the monitoring exporter settings, if
xpack.monitoring.exporters.my_exporter.host is set, we not only want
that xpack.monitoring.exporters.my_exporter.type is set, but that it is
also set to local. This commit extends the settings infrastructure so
that this declaration is possible. The use of this in the monitoring
exporter settings will be implemented in a follow-up.
    @jasontedor
    jasontedor committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    74a7d6a View commit details
    Browse the repository at this point in the history

  2. Fix compilation

    @jasontedor
    jasontedor committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    2451bc4 View commit details
    Browse the repository at this point in the history