Capture stdout and stderr to log4j log #50259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit overrides the stdout and stderr print streams to be redirected to the main elasticsearch.log file. While the Elasticsearch project ensures stdout and stderr are not written to, the jdk or 3rd party libs may do this, which can be unexepected for users used to looking the elasticsearch log. closes elastic#50156
rjernst
added
>enhancement
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
pgomulka
approved these changes
Dec 17, 2019
| throw new IOException("buffer closed"); | ||
| } | ||
| if (b == 0) return; | ||
| if (b == '\n') { |
There was a problem hiding this comment.
so this looks fine in plaintext logs, but might end up harder to analyze with JSON logs. Why not adding \n to the buffer too?
There was a problem hiding this comment.
That would cause double the lines in the log. Think of it as making this equivalent to most of our logging calls do not contain a newline in the message. Log4j inserts newlines per message emitted.
jasontedor
reviewed
Dec 17, 2019
server/src/main/java/org/elasticsearch/common/logging/LoggingOutputStream.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/bwc |
rjernst
added a commit
that referenced
this pull request
Jan 25, 2020
This commit overrides the stdout and stderr print streams to be redirected to the main elasticsearch.log file. While the Elasticsearch project ensures stdout and stderr are not written to, the jdk or 3rd party libs may do this, which can be unexepected for users used to looking the elasticsearch log. closes #50156
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Jan 27, 2020
With this commit we avoid reading from stdout/stderr which might have been closed by the application and rely solely on the process' return code. Relates elastic/elasticsearch#50259
danielmitterdorfer
added a commit
to elastic/rally
that referenced
this pull request
Jan 27, 2020
With this commit we avoid reading from stdout/stderr which might have been closed by the application and rely solely on the process' return code. Relates elastic/elasticsearch#50259
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jan 28, 2020
In elastic#50259 we redirected stdout and stderr to log4j, to capture jdk and external library messages. However, a typo in the method name used to redirect the stream in java means stdout is currently being duplicated twice, and stderr not captured. This commit corrects that mistake. Unfortunately this is at a level that cannot really be tested, thus we are still missing tests for this behavior.
rjernst
added a commit
that referenced
this pull request
Jan 30, 2020
In #50259 we redirected stdout and stderr to log4j, to capture jdk and external library messages. However, a typo in the method name used to redirect the stream in java means stdout is currently being duplicated twice, and stderr not captured. This commit corrects that mistake. Unfortunately this is at a level that cannot really be tested, thus we are still missing tests for this behavior.
rjernst
added a commit
that referenced
this pull request
Jan 30, 2020
In #50259 we redirected stdout and stderr to log4j, to capture jdk and external library messages. However, a typo in the method name used to redirect the stream in java means stdout is currently being duplicated twice, and stderr not captured. This commit corrects that mistake. Unfortunately this is at a level that cannot really be tested, thus we are still missing tests for this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overrides the stdout and stderr print streams to be
redirected to the main elasticsearch.log file. While the Elasticsearch
project ensures stdout and stderr are not written to, the jdk or 3rd
party libs may do this, which can be unexepected for users used to
looking the elasticsearch log.
closes #50156