Fix race condition when stopping a data frame analytics jobs immediately after starting it #50276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
|
run elasticsearch-ci/bwc |
droberts195
changed the title
|
I changed the PR title to something that will be more understandable as a release notes bullet point |
|
run elasticsearch-ci/default-distro |
przemekwitek
force-pushed
the
stop_start_race
branch
from
2801839
to
c8e79cb
Compare
przemekwitek
added a commit
that referenced
this pull request
Dec 17, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current, we don't wait for the native process' PID to become available.
This PR changes that as it tries to wait for a few seconds (currently 10s, can be changed via the
xpack.ml.process_connect_timeoutsetting) when getting process' PID.This should increase chances that when we kill the process, the PID will be already available.
Relates #49680, #50177