Fix accuracy metric #50310
Merged
Fix accuracy metric #50310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
fix_accuracy_metric
branch
5 times, most recently
from
3fbe5af
to
2c08c19
Compare
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
fix_accuracy_metric
branch
3 times, most recently
from
f34a2e6
to
45ca9a7
Compare
benwtrent
reviewed
Dec 19, 2019
.../main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/classification/Accuracy.java
Outdated
Show resolved
Hide resolved
This reverts commit 256d44d.
przemekwitek
force-pushed
the
fix_accuracy_metric
branch
from
751e471
to
44ea9a8
Compare
benwtrent
approved these changes
Dec 20, 2019
.../main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/classification/Accuracy.java
Show resolved
Hide resolved
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 20, 2019
przemekwitek
added a commit
that referenced
this pull request
Dec 20, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes per-class accuracy calculation by taking into account per-class true negatives.
Additionally:
actual_classestoclassesinaccuracymetric for consistency withprecisionandrecallmetricsAccuracyimplemented using 'MulticlassConfusionMatrix`SetOnce<>wrapper in classification metrics classes in order to increase code readabilityRelates #48759