Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adds support for a global calendars #50372

Merged
merged 5 commits into from
Feb 20, 2020

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Dec 19, 2019

This adds _all to Calendar searches. This enables users to supply the _all string in the job_ids array when creating a Calendar. That calendar will now be applied to all jobs (existing and newly created).

Closes #45013

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Member Author

@elasticmachine update branch

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member Author

Currently blocked by: elastic/kibana#53604

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent benwtrent merged commit 1326fdb into elastic:master Feb 20, 2020
@benwtrent benwtrent changed the title [ML] Adds support for a global calendar via _all [ML] Adds support for a global calendars Feb 20, 2020
@benwtrent benwtrent deleted the feature/ml-allow-global-calendar branch February 20, 2020 15:56
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 20, 2020
This adds `_all` to Calendar searches. This enables users to supply the `_all` string in the `job_ids` array when creating a Calendar. That calendar will now be applied to all jobs (existing and newly created).

Closes elastic#45013
benwtrent added a commit that referenced this pull request Feb 20, 2020
This adds `_all` to Calendar searches. This enables users to supply the `_all` string in the `job_ids` array when creating a Calendar. That calendar will now be applied to all jobs (existing and newly created).

Closes #45013

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Calendars : Allow calendar to apply to all jobs
5 participants