Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Correctly read total hits inside watcher config #50614

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

fkelbert
Copy link
Contributor

@fkelbert fkelbert commented Jan 3, 2020

Also see #50611
This might need to be changed in other places as well.

Note: This is because Watcher defaults to "rest_total_hits_as_int" : true in 7.5.

Also see #50611
This might need to be changed in other places as well.
@fkelbert fkelbert added the >docs General docs changes label Jan 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Watcher)

@jrodewig
Copy link
Contributor

Thanks @fkelbert.

@jrodewig jrodewig changed the title Correctly retrieve payload hits in 7.5 [DOCS] Correctly read total hits inside watcher config Jan 16, 2020
@jrodewig jrodewig merged commit 21d0417 into 7.5 Jan 16, 2020
@jrodewig jrodewig deleted the fkelbert-patch-3 branch January 16, 2020 14:34
@fkelbert
Copy link
Contributor Author

Very welcome. Wouldn't this be merged also into 7.6.0?

@jrodewig
Copy link
Contributor

@fkelbert Yes. I'm merging this into 7.5-> master. Working on those backports now.

I'll add a comment containing the backport commits when finished.

jrodewig pushed a commit that referenced this pull request Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value.

This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
jrodewig pushed a commit that referenced this pull request Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value.

This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
@jrodewig
Copy link
Contributor

Backport commits

master: adb56e5
7.x: 584cb0d
7.6: 1433b84
7.5: 21d0417

jrodewig pushed a commit that referenced this pull request Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value.

This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
With elastic#35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value.

This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants