-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update similarity.asciidoc #50719
Update similarity.asciidoc #50719
Conversation
DFRSimilarity -> DFR similarity
Pinging @elastic/es-search (:Search/Ranking) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the correction @blueSky1825821, the change is good, but could you please sign the CLA so we can merge this?
I signed the CLA, please recheck it |
@blueSky1825821 sorry, I cannot find the email you used in this commit in our recods. You might have signed the CLA with a different e-mail than the one used in yout Git commit. Can you add this e-mails into your Github profile (can be hidden), so we can match your e-mails to your Github profile for the CLA checker? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for signing, looks good now. |
DFRSimilarity -> DFR similarity
DFRSimilarity -> DFR similarity
Thanks @blueSky1825821, merged to 7.5 and up. |
DFRSimilarity -> DFR similarity
DFRSimilarity -> DFR similarity
gradle check
?