Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update similarity.asciidoc #50719

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Update similarity.asciidoc #50719

merged 1 commit into from
Jan 8, 2020

Conversation

blueSky1825821
Copy link
Contributor

DFRSimilarity -> DFR similarity

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

DFRSimilarity -> DFR similarity
@cbuescher cbuescher added :Search Relevance/Ranking Scoring, rescoring, rank evaluation. >docs General docs changes v7.5.2 labels Jan 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Ranking)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction @blueSky1825821, the change is good, but could you please sign the CLA so we can merge this?

@blueSky1825821
Copy link
Contributor Author

Thanks for the correction @blueSky1825821, the change is good, but could you please sign the CLA so we can merge this?

I signed the CLA, please recheck it

@cbuescher
Copy link
Member

@blueSky1825821 sorry, I cannot find the email you used in this commit in our recods. You might have signed the CLA with a different e-mail than the one used in yout Git commit. Can you add this e-mails into your Github profile (can be hidden), so we can match your e-mails to your Github profile for the CLA checker?

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbuescher
Copy link
Member

Thanks for signing, looks good now.
I will run the tests.
@elasticmachine test this please

@cbuescher cbuescher merged commit 98f5eff into elastic:7.5 Jan 8, 2020
cbuescher pushed a commit that referenced this pull request Jan 8, 2020
DFRSimilarity -> DFR similarity
cbuescher pushed a commit that referenced this pull request Jan 8, 2020
DFRSimilarity -> DFR similarity
@cbuescher
Copy link
Member

Thanks @blueSky1825821, merged to 7.5 and up.

@blueSky1825821 blueSky1825821 deleted the patch-1 branch January 8, 2020 17:44
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants