Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.x] Security should not reload files that haven't changed #50724

Merged

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jan 8, 2020

In security we currently monitor a set of files for changes:

  • config/role_mapping.yml (or alternative configured path)
  • config/roles.yml
  • config/users
  • config/users_roles

This commit prevents unnecessary reloading when the file change actually doesn't change the internal structure.

Backport of: #50207

Co-authored-by: Anton Shuvaev anton.shuvaev91@gmail.com

In security we currently monitor a set of files for changes:

- config/role_mapping.yml (or alternative configured path)
- config/roles.yml
- config/users
- config/users_roles

This commit prevents unnecessary reloading when the file change actually doesn't change the internal structure.

Backport of: elastic#50207

Co-authored-by: Anton Shuvaev <anton.shuvaev91@gmail.com>
@tvernum tvernum merged commit 293661d into elastic:7.x Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant