Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Typo of ' instead of ` #50767

Merged
merged 1 commit into from
Jan 9, 2020
Merged

[DOCS] Typo of ' instead of ` #50767

merged 1 commit into from
Jan 9, 2020

Conversation

seanstory
Copy link
Member

No description provided.

@jkakavas jkakavas added :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >docs General docs changes labels Jan 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@seanstory seanstory merged commit 3db65e7 into master Jan 9, 2020
@seanstory seanstory deleted the seanstory-patch-1 branch January 9, 2020 15:48
@jkakavas
Copy link
Member

jkakavas commented Jan 9, 2020

Hi @seanstory! Thanks for the fix! We usually wait for at least a LGTM before merging a PR. I understand this was just a small typo but thought I'd mention it.

Cheers!

@seanstory
Copy link
Member Author

@jkakavas sorry, my bad! I assumed otherwise since there wasn't a merge check waiting for a review approval. I thought that was odd, but assumed it was an intentional choice.

@lcawl
Copy link
Contributor

lcawl commented Jan 9, 2020

LGTM, I'll backport now

@lcawl lcawl added the v8.0.0 label Jan 9, 2020
lcawl pushed a commit that referenced this pull request Jan 9, 2020
lcawl pushed a commit that referenced this pull request Jan 9, 2020
@jrodewig jrodewig changed the title Typo of ' instead of ` [DOCS] Typo of ' instead of ` Jan 13, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants