Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Correct typo in ignore_malformed mapping parm docs #50780

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

junmuz
Copy link
Contributor

@junmuz junmuz commented Jan 9, 2020

It should be exists query.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

It should be exists query.
@cbuescher cbuescher added the >docs General docs changes label Jan 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig
Copy link
Contributor

@elasticmachine test this please

@@ -95,7 +95,7 @@ Malformed fields are silently ignored at indexing time when `ignore_malformed`
is turned on. Whenever possible it is recommended to keep the number of
documents that have a malformed field contained, or queries on this field will
become meaningless. Elasticsearch makes it easy to check how many documents
have malformed fields by using `exist` or `term` queries on the special
have malformed fields by using `exists`,`term` or `terms` queries on the special
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically try to use serial commas.

Suggested change
have malformed fields by using `exists`,`term` or `terms` queries on the special
have malformed fields by using `exists`,`term`, or `terms` queries on the special

@jrodewig jrodewig added :Search Foundations/Mapping Index mappings, including merging and defining field types v6.8.7 v7.5.2 v7.6.0 v8.0.0 labels Jan 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@jrodewig
Copy link
Contributor

Thanks for this correction @junmuz!

@jrodewig jrodewig merged commit 5f44085 into elastic:7.5 Jan 13, 2020
@jrodewig jrodewig changed the title Update ignore-malformed.asciidoc [DOCS] Correct typo in ignore_malformed mapping parm docs Jan 13, 2020
@jrodewig
Copy link
Contributor

Backport commits

master: 06cec76
7.x: 6718ce0
7.5: 5f44085
6.8: 624ebb5

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v6.8.7 v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants