Remove Snapshot Tool from 8.0+ #50784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are only using the snapshot tool with JDK8 and it only works until and excluding 7.4.0. There is no point in continuing to have it in `master`. We should maintain it in `7.x` if it ever needs any changes but its unused and just dead code in `master`.
original-brownbear
added
>non-issue
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
@ywelsch I checked this with Paul and he's fine with this removal. |
|
Jenkins run elasticsearch-ci/2 |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
We are only using the snapshot tool with JDK8 and it only works until and excluding 7.4.0. There is no point in continuing to have it in `master`. We should maintain it in `7.x` if it ever needs any changes but its unused and just dead code in `master`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are only using the snapshot tool with JDK8 and it only works until and excluding 7.4.0.
There is no point in continuing to have it in
master. We should maintain it in7.xifit ever needs any changes but its unused and just dead code in
master.