Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated requirement of CCR #50859

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 10, 2020

With retention leases, users do not need to set index.soft_deletes.retention.operations. This change removes it from the requirements of CCR.

@dnhatn dnhatn added >docs General docs changes :Distributed/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.6.0 v7.5.2 v6.8.7 labels Jan 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CCR)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -41,58 +41,3 @@ to a follower the following process will fail due to incomplete history on the l
The default value is `12h`.

For more information about index settings, see {ref}/index-modules.html[Index modules].


[[ccr-overview-beats]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Beats and APM docs link to this section. Can we add a redirect to redirects.asciidoc so these links don't break?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That note (elastic/beats#9427) can be removed from the docs, as it no longer applies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened elastic/beats#15506 to remove the note in the Beats/APM docs. The docs CI tests will continue to fail for this PR until that's merged or we add a redirect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnhatn elastic/beats#15506 is now merged. If you update this branch, the docs CI test should pick up the changes in Beats and pass.

@dnhatn
Copy link
Member Author

dnhatn commented Jan 13, 2020

run elasticsearch-ci/docs

@jrodewig
Copy link
Contributor

@dnhatn Looks like my PR missed a link. Opened elastic/apm-server#3147 to remove.

@jrodewig
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@dnhatn
Copy link
Member Author

dnhatn commented Jan 14, 2020

@jasontedor @jrodewig Thanks for reviewing.

@dnhatn dnhatn merged commit ac8f5cd into elastic:master Jan 14, 2020
@dnhatn dnhatn deleted the cleanup-ccr-doc branch January 14, 2020 00:59
dnhatn added a commit that referenced this pull request Jan 14, 2020
With retention leases, users do not need to set 
index.soft_deletes.retention.operations. This change removes it from the
requirements of CCR
dnhatn added a commit that referenced this pull request Jan 14, 2020
With retention leases, users do not need to set 
index.soft_deletes.retention.operations. This change removes it from the
requirements of CCR
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jan 14, 2020
With retention leases, users do not need to set
index.soft_deletes.retention.operations. This change removes it from the
requirements of CCR
dnhatn added a commit that referenced this pull request Jan 14, 2020
With retention leases, users do not need to set
index.soft_deletes.retention.operations. This change removes it from the
requirements of CCR.

Backport of #50859
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
With retention leases, users do not need to set 
index.soft_deletes.retention.operations. This change removes it from the
requirements of CCR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features >docs General docs changes v6.8.7 v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants