Fix format problem in composite of unmapped #50869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a composite aggregation is reduced using the results from an index that has one of the fields unmapped we were throwing away the formatter. This is mildly annoying, except in the case of IP addresses which were coming out as non-utf-8-characters. And tripping assertions. This carefully preserves the formatter from the working bucket. Closes elastic#50600
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
nik9000
commented
Jan 10, 2020
| @Override | ||
| public String toString() { | ||
| return "ip"; | ||
| } |
There was a problem hiding this comment.
I added these to help with debugging and figure they are probably fine to keep.
nik9000
force-pushed
the
composite_ip_mixed
branch
from
6e3bc8c
to
be7d304
Compare
not-napoleon
approved these changes
Jan 10, 2020
| @@ -249,6 +251,30 @@ public void testReduceSame() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Check that reducing with an unmapped index produces useful formats. | |||
There was a problem hiding this comment.
Thank you for including a note of what we're testing, helps so much when debugging test failures!
|
Thanks @not-napoleon and @jimczi ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 10, 2020
When a composite aggregation is reduced using the results from an index that has one of the fields unmapped we were throwing away the formatter. This is mildly annoying, except in the case of IP addresses which were coming out as non-utf-8-characters. And tripping assertions. This carefully preserves the formatter from the working bucket. Closes elastic#50600
nik9000
added a commit
that referenced
this pull request
Jan 10, 2020
When a composite aggregation is reduced using the results from an index that has one of the fields unmapped we were throwing away the formatter. This is mildly annoying, except in the case of IP addresses which were coming out as non-utf-8-characters. And tripping assertions. This carefully preserves the formatter from the working bucket. Closes #50600
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 17, 2020
Now that we've backported elastic#50869 we can update the skip config for its test.
nik9000
added a commit
that referenced
this pull request
Jan 17, 2020
Now that we've backported #50869 we can update the skip config for its test.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
When a composite aggregation is reduced using the results from an index that has one of the fields unmapped we were throwing away the formatter. This is mildly annoying, except in the case of IP addresses which were coming out as non-utf-8-characters. And tripping assertions. This carefully preserves the formatter from the working bucket. Closes elastic#50600
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Now that we've backported elastic#50869 we can update the skip config for its test.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a composite aggregation is reduced using the results from an
index that has one of the fields unmapped we were throwing away the
formatter. This is mildly annoying, except in the case of IP addresses
which were coming out as non-utf-8-characters. And tripping assertions.
This carefully preserves the formatter from the working bucket.
Closes #50600