Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nested and aliased fields correctly when copying mapping. #50918

Merged

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jan 13, 2020

Currently, the mapping of a dependent variable which is either nested (outer.inner) or an alias is handled incorrectly.
This PR fixes it as it always fetches the mapping of a concrete field (i.e. the field that alias is pointing to).
Also it allows nested dependent variables as it traverses the path using extractValue method rather than simple get.

Relates #50787

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek force-pushed the fix_dep_var_of_type_alias_problem branch 3 times, most recently from 0bca009 to 498b765 Compare January 13, 2020 16:10
@przemekwitek przemekwitek removed the WIP label Jan 13, 2020
@benwtrent benwtrent self-requested a review January 13, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants