Guard against null settings in CCRIndexLifecycleIT #51008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that the index could return no settings and thus throw a `NullPointerException`. I wasn't able to reproduce the original issue, but this should guard against in the future. Resolves elastic#50646
dakrone
added
>non-issue
>test
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
andreidan
approved these changes
Jan 15, 2020
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 15, 2020
It's possible that the index could return no settings and thus throw a `NullPointerException`. I wasn't able to reproduce the original issue, but this should guard against in the future. Resolves elastic#50646
dakrone
added a commit
that referenced
this pull request
Jan 15, 2020
It's possible that the index could return no settings and thus throw a `NullPointerException`. I wasn't able to reproduce the original issue, but this should guard against in the future. Resolves #50646 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
It's possible that the index could return no settings and thus throw a `NullPointerException`. I wasn't able to reproduce the original issue, but this should guard against in the future. Resolves elastic#50646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that the index could return no settings and thus throw a
NullPointerException.I wasn't able to reproduce the original issue, but this should guard
against in the future.
Resolves #50646