Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail gracefully on invalid token strings #51014

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Fail gracefully on invalid token strings #51014

merged 2 commits into from
Jan 16, 2020

Commits on Jan 14, 2020

  1. Fail gracefully on invalid token strings 

    When we receive a request with an Authorization header that contains
a Bearer token that is not generated by us or that is malformed in
some way, attempting to decode it as one of our own might cause a
number of exceptions that are not IOExceptions. This commit ensures
that we catch and log these too and call onResponse with `null, so
that we can return 401 instead of 500.

Resolves: elastic#50497
    @jkakavas
    jkakavas committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    fc5d912 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into tokenservice-decode… 

    …-exceptions
    @jkakavas
    jkakavas committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    6d014aa View commit details
    Browse the repository at this point in the history