Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt generated key with AES #51019

Merged
merged 5 commits into from
Jan 15, 2020
Merged

Encrypt generated key with AES #51019

merged 5 commits into from
Jan 15, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Jan 15, 2020

Replace DES with AES to align with modern encryption standards

Resolves: #50843

Replace DES with AES to align with modern encryption standards

Resolves: elastic#50843
@ywangd ywangd self-assigned this Jan 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Network)

@ywangd ywangd added the v7.6.0 label Jan 15, 2020
@tvernum
Copy link
Contributor

tvernum commented Jan 15, 2020

@ywangd Can you modify the title of the PR to refer to key rather than cert?
Thanks.

@ywangd ywangd changed the title Encrypt generated cert with AES Encrypt generated key with AES Jan 15, 2020
@ywangd
Copy link
Member Author

ywangd commented Jan 15, 2020

Failure is genuine. Because of randomness, sometimes the key file does not have any encryption. Will fix it.

@ywangd ywangd closed this Jan 15, 2020
@tvernum
Copy link
Contributor

tvernum commented Jan 15, 2020

@ywangd Did you accidentally close this?

@ywangd
Copy link
Member Author

ywangd commented Jan 15, 2020

Must be me then. Sorry reopenning

@ywangd ywangd reopened this Jan 15, 2020
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit 755c3fd into elastic:master Jan 15, 2020
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Jan 15, 2020
Replace DES with AES to align with modern encryption standards

Resolves: elastic#50843
ywangd added a commit that referenced this pull request Jan 16, 2020
Replace DES with AES to align with modern encryption standards
Backport also fixs Files.readString API that is not available in Java 8

Resolves: #50843
@ywangd
Copy link
Member Author

ywangd commented Jan 16, 2020

Done backport to 7.x

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Replace DES with AES to align with modern encryption standards

Resolves: elastic#50843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypt PEM files with AES
6 participants