Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean soft-deletes setting in ccr tests #51113

Merged
merged 4 commits into from Jan 20, 2020
Merged

Clean soft-deletes setting in ccr tests #51113

merged 4 commits into from Jan 20, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 16, 2020 •
edited

We no longer need to explicitly enable soft-deletes in CCR tests.

Relates #50775

@dnhatn dnhatn added >non-issue :Distributed/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.7.0 labels Jan 16, 2020
@dnhatn dnhatn requested a review from ywelsch January 16, 2020 16:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CCR)

@dnhatn
Copy link
Member Author

dnhatn commented Jan 16, 2020

Please hold off the review. We need to make soft-deletes mandatory and stop disabling soft-deletes in tests.

@dnhatn dnhatn removed the request for review from ywelsch January 16, 2020 18:53
@dnhatn dnhatn requested a review from ywelsch January 18, 2020 19:34
@dnhatn dnhatn removed the v7.7.0 label Jan 18, 2020
@dnhatn dnhatn mentioned this pull request Jan 18, 2020
Closed
14 tasks
ywelsch
ywelsch approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's backport this to 7.x as well, to make future backports to these tests easier.

@dnhatn
Copy link
Member Author

dnhatn commented Jan 20, 2020

Let's backport this to 7.x as well, to make future backports to these tests easier.

Yeah, I will try back port as many files as possible. Thanks for reviewing.

@dnhatn dnhatn added the v7.7.0 label Jan 20, 2020
@dnhatn dnhatn merged commit 698b1e9 into elastic:master Jan 20, 2020
@dnhatn dnhatn deleted the clean-ccr-soft-deletes-setting branch January 20, 2020 15:49
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@dnhatn @SivagurunathanV
Clean soft-deletes setting in ccr tests (elastic#51113)
8ca83e0 
We no longer need to explicitly enable soft-deletes in CCR tests.

Relates elastic#50775
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jan 23, 2020
@dnhatn
Clean soft-deletes setting in ccr tests (elastic#51113)
b4c0439 
We no longer need to explicitly enable soft-deletes in CCR tests.

Relates elastic#50775
@dnhatn dnhatn mentioned this pull request Jan 23, 2020
Merged
dnhatn added a commit that referenced this pull request Jan 23, 2020
@dnhatn
Clean soft-deletes setting in ccr tests (#51113) (#51372)
072203c 
We no longer need to explicitly enable soft-deletes in CCR tests.

Relates #50775
Backport of #51113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

Assignees
No one assigned
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features >non-issue v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dnhatn @elasticmachine @ywelsch @jakelandis