Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits to Ranking Evaluation API docs #51116

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Conversation

liebeslied
Copy link
Contributor

For the sake of clarity, fix some small grammar/syntax issues and change some wordings.

Small updates to grammar, syntax, and unclear wordings
@cbuescher cbuescher added :Search Relevance/Ranking Scoring, rescoring, rank evaluation. >docs General docs changes labels Jan 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Ranking)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @liebeslied, thanks for opening the PR, it great to see how much this improves the readability of this particular section in the docs. Many thanks for that. I left a small request for change (if you agree with me), other than that I will run some requires CI tests and will merge as soon as you were able to reply to my suggestion below (... and I will work on my use of the possessive 's in English, as a non-native speaker, having written most of these docs its great to get this kind of feedback).

docs/reference/search/rank-eval.asciidoc Outdated Show resolved Hide resolved
updating Ranking Evaluation API docs

Co-Authored-By: Christoph Büscher <cbuescher@posteo.de>
@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit ab11411 into elastic:7.5 Jan 20, 2020
cbuescher pushed a commit that referenced this pull request Jan 20, 2020
Small updates to grammar, syntax, and unclear wordings.
cbuescher pushed a commit that referenced this pull request Jan 20, 2020
Small updates to grammar, syntax, and unclear wordings.
cbuescher pushed a commit that referenced this pull request Jan 20, 2020
Small updates to grammar, syntax, and unclear wordings.
@cbuescher
Copy link
Member

Thanks again @liebeslied, merged the PR to 7.5 and newer branches.

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Small updates to grammar, syntax, and unclear wordings.
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v7.5.2 v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants