SourceExists HLRC uses GetSourceRequest instead of GetRequest #51789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsantos20
suggested changes
Feb 2, 2020
There was a problem hiding this comment.
Hi @timoninmaxim i would suggest you to break your pr in small commits to help others to review your change
martijnvg
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Thanks @timoninmaxim! Besides a small comment, this change looks good to me.
| @@ -184,7 +180,7 @@ private static void doTestSourceExists(BiFunction<String, String, GetRequest> re | |||
| if (randomBoolean()) { | |||
| boolean realtime = randomBoolean(); | |||
| getRequest.realtime(realtime); | |||
| if (realtime == false) { | |||
| if (!realtime) { | |||
There was a problem hiding this comment.
In the es code base we prefer use == false instead of !. The reason is that this is more visible when reading the code. A ! can easily be missed or forgotten to be added.
There was a problem hiding this comment.
thanks for the clarification! fixed it.
|
@elasticmachine test this please |
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #50885
Link to the discussion
Source Exists API currently uses GetRequest that contains unsupported fields like
stored_fields,versionandversion_type. So restrict the API to use GetSourceRequest and deprecates previous version.