[Transform] improve irrecoverable error detection - part 2 #52003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
|
run elasticsearch-ci/bwc |
hendrikmuhs
force-pushed
the
transform-error-handling-using-rest-status
branch
from
4dc601e
to
f8a1d01
Compare
...ransform/src/main/java/org/elasticsearch/xpack/transform/utils/ExceptionRootCauseFinder.java
Outdated
Show resolved
Hide resolved
...ransform/src/main/java/org/elasticsearch/xpack/transform/utils/ExceptionRootCauseFinder.java
Show resolved
Hide resolved
...ransform/src/main/java/org/elasticsearch/xpack/transform/utils/ExceptionRootCauseFinder.java
Outdated
Show resolved
Hide resolved
...n/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformIndexer.java
Outdated
Show resolved
Hide resolved
added 2 commits
February 12, 2020 09:45
hendrikmuhs
force-pushed
the
transform-error-handling-using-rest-status
branch
from
f8a1d01
to
1b1505b
Compare
przemekwitek
approved these changes
Feb 12, 2020
| private static void assertFirstException(Collection<BulkItemResponse> bulkItemResponses, Class<?> expectedClass, String message) { | ||
| Throwable t = ExceptionRootCauseFinder.getFirstIrrecoverableExceptionFromBulkResponses(bulkItemResponses); | ||
| assertNotNull(t); | ||
| assertEquals(t.getClass(), expectedClass); |
There was a problem hiding this comment.
assertThat(..., equalTo(...))
?
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 12, 2020
base error handling on rest status instead of listing individual exception types relates to #51820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base error handling on rest status instead of listing individual exception types
relates to #51820