[ML] Better error when persistent task assignment disabled #52014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the misleading error message when attempting to open a job while the "cluster.persistent_tasks.allocation.enable" setting is set to "none" to a clearer message that names the setting. Closes elastic#51956
|
Pinging @elastic/ml-core (:ml) |
droberts195
commented
Feb 6, 2020
| exception = makeNoSuitableNodesException(logger, params.getJobId(), assignment.getExplanation()); | ||
| if (assignment.equals(AWAITING_UPGRADE)) { | ||
| exception = makeCurrentlyBeingUpgradedException(logger, params.getJobId(), assignment.getExplanation()); | ||
| } else if (assignment.getExplanation().contains("[" + EnableAssignmentDecider.ALLOCATION_NONE_EXPLANATION + "]")) { |
There was a problem hiding this comment.
It's not ideal that this is done using contains. The better solution would be to make Assignments contain a reason number or enum value as well as a text reason. Then we could check that. But that's obviously a pretty far-reaching change. It may be worth waiting until there are more use cases for a reason code so that any implementation can take all the use cases into account.
benwtrent
approved these changes
Feb 6, 2020
|
Just checked the error displayed in kibana, looks good:
|
droberts195
added a commit
that referenced
this pull request
Feb 11, 2020
Changes the misleading error message when attempting to open a job while the "cluster.persistent_tasks.allocation.enable" setting is set to "none" to a clearer message that names the setting. Closes #51956
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the misleading error message when attempting to open
a job while the "cluster.persistent_tasks.allocation.enable"
setting is set to "none" to a clearer message that names the
setting.
Closes #51956