HLRC support for string_stats #52163
Conversation
This adds a builder and parsed results for the `string_stats` aggregation directly to the high level rest client. Without this the HLRC can't access the `string_stats` API without the elastic licensed `analytics` module. While I'm in there this adds a few of our usual unit tests and modernizes the parsing.
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
This is a work in progress because I don't have the horsepower to run all the tests at the moment. So I'm making Jenkins do it. I think this is how I want to expose analytics aggs to the HLRC, though the hack with the builder is unfortunate. |
nik9000
changed the title
|
I've removed |
the test wants it.....
|
@imotov you mentioned a while back that you were interested in talking about HLRC support for the analytics aggs. This is my take on explicit support for the |
| Map<String, Long> charOccurrences = instance.getCharOccurrences(); | ||
| boolean showDistribution = instance.getShowDistribution(); | ||
| switch (between(0, 6)) { | ||
| case 0: |
There was a problem hiding this comment.
That indentation looks a bit strange to me.
There was a problem hiding this comment.
It is the true indentation for case statements!
There was a problem hiding this comment.
It is indeed, we just don't use it anywhere else :) that's why it looks strange.
There was a problem hiding this comment.
It is the Eclipse standard but not the intellij standard. I prefer this was but I'm not picky.
| import static org.hamcrest.Matchers.equalTo; | ||
| import static org.hamcrest.Matchers.hasEntry; | ||
|
|
||
| public class StringStatsIT extends ESRestHighLevelClientTestCase { |
There was a problem hiding this comment.
Just wonder if we should rename this to AnalyticsAggsIT or something like this, so we can add other agg tests from analytics plugin here as we add convert them to work with the rest client.
Do you think we should move |
Like, as part of a separate change. Not this one. |
|
That's the challenge |
+2 |
This adds a builder and parsed results for the `string_stats` aggregation directly to the high level rest client. Without this the HLRC can't access the `string_stats` API without the elastic licensed `analytics` module. While I'm in there this adds a few of our usual unit tests and modernizes the parsing.
This adds a builder and parsed results for the `string_stats` aggregation directly to the high level rest client. Without this the HLRC can't access the `string_stats` API without the elastic licensed `analytics` module. While I'm in there this adds a few of our usual unit tests and modernizes the parsing.
|
Thanks @imotov ! |
This adds a builder and parsed results for the
string_statsaggregation directly to the high level rest client. Without this the
HLRC can't access the
string_statsAPI without the elastic licensedanalyticsmodule.While I'm in there this adds a few of our usual unit tests and
modernizes the parsing.