Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize how queries on _index are handled at rewrite time #52486

Merged
merged 37 commits into from
Feb 26, 2020

Commits on Nov 29, 2019

  1. Introduce a singleton_keyword field.

    This field is a specialization of the `keyword` field for the case when all
    documents have the same value. It typically performs more efficiently than
    keywords at query time by figuring out whether all or none of the documents
    match at rewrite time, like `term` queries on `_index`.
    
    The name is up for discussion. I liked including `keyword` in it, so that we
    still have room for a `singleton_numeric` in the future. However I'm unsure
    whether to call it `singleton`, `constant` or something else, any opinions?
    
    For this field there is a choice between
     1. accepting values in `_source` when they are equal to the value configured
        in mappings, but rejecting mapping updates
     2. rejecting values in `_source` but then allowing updates to the value that
        is configured in the mapping
    This commit implements option 1, so that it is possible to reindex from/to an
    index that has the field mapped as a keyword with no changes to the source.
    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    db1a079 View commit details
    Browse the repository at this point in the history
  2. iter

    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c253ce7 View commit details
    Browse the repository at this point in the history
  3. Rename to constant_keyword.

    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    abf27f1 View commit details
    Browse the repository at this point in the history
  4. iter

    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    002fe96 View commit details
    Browse the repository at this point in the history
  5. iter

    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c6738d8 View commit details
    Browse the repository at this point in the history
  6. iter

    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    b7b894e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f5f288e View commit details
    Browse the repository at this point in the history
  8. iter

    jpountz committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    a86ad8a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. iter

    jpountz committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    a5949d6 View commit details
    Browse the repository at this point in the history
  2. iter

    jpountz committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c9c43aa View commit details
    Browse the repository at this point in the history
  3. iter

    jpountz committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    6b907c2 View commit details
    Browse the repository at this point in the history
  4. unused imports

    jpountz committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    779d128 View commit details
    Browse the repository at this point in the history
  5. add javadocs

    jpountz committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    51dc118 View commit details
    Browse the repository at this point in the history
  6. iter

    jpountz committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8da5b6c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Configuration menu
    Copy the full SHA
    af4a55a View commit details
    Browse the repository at this point in the history
  2. More docs.

    jpountz committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    d1b71f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Configuration menu
    Copy the full SHA
    f8ddbf7 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. address review comments

    jpountz committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    d346303 View commit details
    Browse the repository at this point in the history
  2. Fix failures.

    jpountz committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    c378cdf View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Configuration menu
    Copy the full SHA
    59fd6b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4592af2 View commit details
    Browse the repository at this point in the history
  3. iter

    jpountz committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    ab70f10 View commit details
    Browse the repository at this point in the history
  4. iter

    jpountz committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    0b29a43 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. iter

    jpountz committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    936f883 View commit details
    Browse the repository at this point in the history
  2. Undo renames.

    jpountz committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    44a7170 View commit details
    Browse the repository at this point in the history
  3. iter

    jpountz committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    7639d34 View commit details
    Browse the repository at this point in the history
  4. iter

    jpountz committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    fba9ca3 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Configuration menu
    Copy the full SHA
    a284be9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. iter

    jpountz committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    f9a23e2 View commit details
    Browse the repository at this point in the history
  2. iter

    jpountz committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    b312407 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    437315d View commit details
    Browse the repository at this point in the history
  4. iter

    jpountz committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3f94930 View commit details
    Browse the repository at this point in the history
  5. iter

    jpountz committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    7cd5c6d View commit details
    Browse the repository at this point in the history
  6. iter

    jpountz committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    51f7b3c View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Configuration menu
    Copy the full SHA
    dc0bf44 View commit details
    Browse the repository at this point in the history
  2. Review comments.

    jpountz committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    15af22f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Configuration menu
    Copy the full SHA
    2b00751 View commit details
    Browse the repository at this point in the history