SQL: Use calendar_interval of 1d for HISTOGRAMs with 1 DAY intervals #52749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (:Search/SQL) |
matriv
reviewed
Feb 25, 2020
There was a problem hiding this comment.
LGTM. Maybe for completeness we could add unit test for the case of a function: https://github.com/elastic/elasticsearch/pull/52749/files#diff-4d4ca1fe9d2bf59cd1e9e61889fa691cR351
something like INTERVAL(date + INTERVAL 5 DAYS, INTERVAL 1 DAY).
matriv
approved these changes
Feb 25, 2020
bpintea
approved these changes
Feb 25, 2020
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Feb 25, 2020
…lastic#52749) (cherry picked from commit 556f5fa)
astefan
added a commit
that referenced
this pull request
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #52713.