-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds the class_assignment_objective parameter to classification #52763
[ML] Adds the class_assignment_objective parameter to classification #52763
Conversation
Pinging @elastic/ml-core (:ml) |
63aa35d
to
edfebc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few things to address.
client/rest-high-level/src/main/java/org/elasticsearch/client/ml/dataframe/Classification.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/elasticsearch/client/MachineLearningIT.java
Show resolved
Hide resolved
...in/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/Classification.java
Outdated
Show resolved
Hide resolved
Thanks for the review @dimitris-athanasiou. I've addressed all your comments. Can you take another look? |
run elasticsearch-ci/bwc |
run elasticsearch-ci/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Now just waiting for those green lights!
Until #52763 is backported to 7.x.
Adds a new parameter for classification that enables choosing whether to assign labels to maximise accuracy or to maximise the minimum class recall.
#52427.