SQL: use a proper error message for queries directed at empty mapping indices #52967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (:Search/SQL) |
costin
reviewed
Feb 29, 2020
| // Create an index without any types | ||
| Request request = new Request("PUT", "/test"); | ||
| request.setJsonEntity("{}"); | ||
| client().performRequest(request); | ||
|
|
||
| assertFoundOneProblem(command("SELECT * FROM test")); | ||
| //assertEquals("line 1:15: [test] doesn't have any types so it is incompatible with sql" + END, readLine()); | ||
| assertEquals("line 1:15: Unknown index [test]" + END, readLine()); | ||
| assertEquals("line 1:8: Cannot determine columns for [*]" + END, readLine()); |
There was a problem hiding this comment.
I think this is incorrect - if we know the index is empty, we should return no columns since we can determine them and know there are none.
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Mar 2, 2020
…ng (elastic#52967) (cherry picked from commit a0bd83a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, when a query was executed against an index that had no mapping a misleading "index not found" error message was issued. This PR fixes this error message by pointing out the columns not being found instead.
Fixes #52865.