[ML] Improve DF analytics audits and logging #53179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds audits for when the job starts reindexing, loading data, analyzing, writing results. Also adds some info logging.
|
Pinging @elastic/ml-core (:ml) |
benwtrent
approved these changes
Mar 5, 2020
przemekwitek
approved these changes
Mar 5, 2020
| @@ -233,6 +233,8 @@ protected static void assertThatAuditMessagesMatch(String configId, String... ex | |||
| // Since calls to write the AbstractAuditor are sent and forgot (async) we could have returned from the start, | |||
| // finished the job (as this is a very short analytics job), all without the audit being fully written. | |||
| assertBusy(() -> assertTrue(indexExists(NotificationsIndex.NOTIFICATIONS_INDEX))); | |||
| client().admin().indices().prepareRefresh(".ml-notifications*").get(); | |||
There was a problem hiding this comment.
Is this needed taking into account that fetchAllAuditMessages also issues refresh request?
There was a problem hiding this comment.
Ah, good point. That comment got me confused. I'll remove.
dimitris-athanasiou
deleted the
audit-df-analytics-progress-phase-changes
branch
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds audits for when the job starts reindexing, loading data,
analyzing, writing results. Also adds some info logging.