Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow _cat indices & aliases to use indices options #53248

Merged
merged 18 commits into from
Mar 13, 2020

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Mar 6, 2020

This commit adjusts the _cat/indices and _cat/aliases APIs to allow
specifying indices options, so that these APIs can handle hidden
indices/aliases in the same way as other APIs.

Also adds the hidden option to the expand_wildcards parameter
in the YAML spec for every API that accepts it.

Relates #52304

This commit adjusts the _cat/indices and _cat/aliases APIs to allow
specifying indices options, so that these APIs can handle hidden
indices/aliases in the same way as other APIs.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looking forward for this feature being merged.

@gwbrown gwbrown removed the WIP label Mar 11, 2020
@gwbrown gwbrown marked this pull request as ready for review March 11, 2020 23:46
@gwbrown gwbrown assigned jaymode and unassigned jaymode Mar 11, 2020
@gwbrown gwbrown requested a review from jaymode March 11, 2020 23:46
Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and good job spotting the enum value in rest spec! I left some minor comments

@gwbrown gwbrown requested a review from jaymode March 12, 2020 23:57
Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown
Copy link
Contributor Author

gwbrown commented Mar 13, 2020

@elasticmachine update branch

@gwbrown gwbrown merged commit d7bbc9d into elastic:master Mar 13, 2020
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Mar 13, 2020
This commit adjusts the _cat/indices and _cat/aliases APIs to allow
specifying indices options, so that these APIs can handle hidden
indices/aliases in the same way as other APIs.

Also adds the hidden option to the expand_wildcards parameter
in the YAML spec for every API that accepts it.
gwbrown added a commit that referenced this pull request Mar 16, 2020
This commit adjusts the _cat/indices and _cat/aliases APIs to allow
specifying indices options, so that these APIs can handle hidden
indices/aliases in the same way as other APIs.

Also adds the hidden option to the expand_wildcards parameter
in the YAML spec for every API that accepts it.
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Apr 16, 2020
Relates: elastic/elasticsearch#52547
Relates: elastic/elasticsearch#53248

This commit adds the ability to mark indices
and aliases as hidden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants