Perform evaluation in multiple steps when necessary #53295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
fix_evaluation_bug
branch
4 times, most recently
from
1ab682c
to
baff92b
Compare
|
Pinging @elastic/ml-core (:ml) |
droberts195
reviewed
Mar 11, 2020
...gin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportEvaluateDataFrameAction.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
fix_evaluation_bug
branch
from
f2d0f66
to
d857604
Compare
|
run elasticsearch-ci/default-distro |
|
run elasticsearch-ci/bwc |
przemekwitek
force-pushed
the
fix_evaluation_bug
branch
from
c43ba38
to
0e13a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs evaluation aggregations in batches when performing a single request would cause
too_many_buckets_exception.It takes into account the
search.max_bucketssetting. The setting is passed to all the metrics usingSettingsobject so the interface ofEvaluationMetric::aggsmethod had to be extended.For the default value of
search.max_bucketssetting (10000) there will be more than 100 sequential steps making the_evaluaterequest somewhat slow. But for now I think it's better to provide slow response rather than no response at all.