Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date_nanos in composite aggs (#53315) #53347

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Fix date_nanos in composite aggs (#53315) #53347

merged 2 commits into from
Mar 11, 2020

Commits on Mar 10, 2020

  1. Fix date_nanos in composite aggs (elastic#53315) 

    It looks like `date_nanos` fields weren't likely to work properly in
composite aggs because composites iterate field values using points and
we weren't converting the points into milliseconds. Because the doc
values were coming back in milliseconds we ended up geting very confused
and just never collecting sub-aggregations.

This fixes that by adding a method to `DateFieldMapper.Resolution` to
`parsePointAsMillis` which is similarly in name and function to
`NumberFieldMapper.NumberType`'s `parsePoint` except that it normalizes
to milliseconds which is what aggs need at the moment.

Closes elastic#53168
    @nik9000
    nik9000 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    39f2f2c View commit details
    Browse the repository at this point in the history

  2. 6.8.8

    @nik9000
    nik9000 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7f0d9de View commit details
    Browse the repository at this point in the history