Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] renaming inference processor field field_mappings to new name field_map #53433

Merged
merged 5 commits into from
Mar 12, 2020
Merged

[ML] renaming inference processor field field_mappings to new name field_map #53433

merged 5 commits into from
Mar 12, 2020

Conversation

benwtrent
Copy link
Member

This renames the inference processor configuration field field_mappings to field_map.

field_mappings is now deprecated.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Member Author

@elasticmachine update branch

davidkyle
davidkyle approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.../plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/ingest/InferenceProcessor.java
fieldMap = ConfigurationUtils.readOptionalMap(TYPE, tag, config, FIELD_MAPPINGS);
//TODO Remove in 8.x
if (fieldMap != null) {
LoggingDeprecationHandler.INSTANCE.usedDeprecatedName(FIELD_MAPPINGS, FIELD_MAP);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidkyle davidkyle mentioned this pull request Mar 12, 2020
Merged
@benwtrent benwtrent merged commit 970f726 into elastic:master Mar 12, 2020
@benwtrent benwtrent deleted the feature/ml-inference-rename-field_mappings-parameter branch March 12, 2020 16:49
@benwtrent benwtrent mentioned this pull request Mar 12, 2020
Merged
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 12, 2020
@benwtrent
[ML] renaming inference processor field field_mappings to new name fi…
55ada41 
…eld_map (elastic#53433)

This renames the `inference` processor configuration field `field_mappings` to `field_map`.

`field_mappings` is now deprecated.
@szabosteve szabosteve mentioned this pull request Mar 13, 2020
Merged
benwtrent added a commit that referenced this pull request Mar 13, 2020
@benwtrent
[ML] renaming inference processor field field_mappings to new name fi…
4e43ede 
…eld_map (#53433) (#53502)

This renames the `inference` processor configuration field `field_mappings` to `field_map`.

`field_mappings` is now deprecated.
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
>deprecation :ml Machine learning v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benwtrent @elasticmachine @davidkyle @jakelandis