Add server name to remote info API #53634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the configured server_name to the proxy mode info so that it can be exposed in the remote info API.
jasontedor
added
>enhancement
:Distributed/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
|
@elasticmachine update branch |
jasontedor
added a commit
that referenced
this pull request
Mar 17, 2020
This commit adds the configured server_name to the proxy mode info so that it can be exposed in the remote info API.
|
@jasontedor / @tbrooks8 I think I may have found a bug with this change. If I create a remote cluster with the proxy mode and server_name defined (e.g., "foo"), change the server_name value (e.g., "bar") via |
|
There is a bug and it looks like |
|
Thanks @tbrooks8. |
|
I opened #54107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the configured server_name to the proxy mode info so that it can be exposed in the remote info API.