[Transform][Rollup] add processing stats to record the time spent for processing results #53770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
>enhancement
:StorageEngine/Rollup
|
Pinging @elastic/es-analytics-geo (:Analytics/Rollup) |
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
reviewed
Mar 19, 2020
...e/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformIndexerStats.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/elasticsearch/xpack/core/transform/transforms/TransformStatsTests.java
Show resolved
Hide resolved
benwtrent
approved these changes
Mar 23, 2020
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private static <T> T unboxSafe(Object l, T default_value) { |
|
❤️ |
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Mar 23, 2020
…tic#53770) add 2 additional stats: processing time and processing total which capture the time spent for processing results and how often it ran. The 2 new stats correspond to the existing indexing and search stats. Together with indexing and search this now allows the user to see the full picture, all 3 stages.
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 2 additional stats: processing time and processing total which capture the time spent for processing results and how often it ran. The 2 new stats correspond to the existing indexing and search stats. Together with indexing and search this now allows the user to see the full picture, all 3 stages.
Note: Processing time is not expected to use a significant amount of time, however a user that looks at rollup/transform as black box this is not a given. Having stats for all 3 stages allows a complete view. LBNL result processing might have a bug, it's also possible that processing gets more complicated in future.
processingmade sense to me, if you have better name suggestion, please let me know.