[ML] Data frame analytics analysis stats #53788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds parsing and indexing of analysis instrumentation stats. The latest one is also returned from the get-stats API. Note that we chose to duplicate objects even where they are currently similar. There are already ideas on how these will diverge in the future and while the duplication looks ugly at the moment, it is the option that offers the highest flexibility.
|
Pinging @elastic/ml-core (:ml) |
benwtrent
reviewed
Mar 19, 2020
There was a problem hiding this comment.
I have an overall concern with HLRC.
By making these fields ctor parse fields unboxed and mandatory, we restrict hlrc compatibility as it cannot ever handle those fields becoming optional or being null.
Do you think we should all these to be optional (at least when parsing from xcontent). We can still make them mandatory in the object by unboxing to zero values.
...rc/main/java/org/elasticsearch/client/ml/dataframe/stats/classification/Hyperparameters.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/client/ml/dataframe/stats/classification/Hyperparameters.java
Outdated
Show resolved
Hide resolved
...el/src/main/java/org/elasticsearch/client/ml/dataframe/stats/classification/TimingStats.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/client/ml/dataframe/stats/classification/ValidationLoss.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/elasticsearch/client/ml/dataframe/stats/outlierdetection/Parameters.java
Outdated
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/core/ml/dataframe/stats/outlierdetection/TimingStats.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/stats/regression/TimingStats.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/core/ml/dataframe/stats/regression/ValidationLoss.java
Outdated
Show resolved
Hide resolved
...va/org/elasticsearch/xpack/core/ml/action/GetDataFrameAnalyticsStatsActionResponseTests.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/client/ml/dataframe/stats/outlierdetection/TimingStats.java
Outdated
Show resolved
Hide resolved
|
@benwtrent I addressed your comments. For now I made fields optional where necessary and kept them simply boxed. |
benwtrent
approved these changes
Mar 19, 2020
...l/src/main/java/org/elasticsearch/client/ml/dataframe/stats/outlierdetection/Parameters.java
Outdated
Show resolved
Hide resolved
...va/org/elasticsearch/xpack/core/ml/action/GetDataFrameAnalyticsStatsActionResponseTests.java
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
pushed a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Mar 20, 2020
Until elastic#53788 is backported to 7.x.
This was referenced Mar 20, 2020
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 20, 2020
Until #53788 is backported to 7.x.
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 20, 2020
Adds parsing and indexing of analysis instrumentation stats. The latest one is also returned from the get-stats API. Note that we chose to duplicate objects even where they are currently similar. There are already ideas on how these will diverge in the future and while the duplication looks ugly at the moment, it is the option that offers the highest flexibility. Backport of #53788
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Mar 20, 2020
... after backporting elastic#53788
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 20, 2020
... after backporting #53788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parsing and indexing of analysis instrumentation stats.
The latest one is also returned from the get-stats API.
Note that we chose to duplicate objects even where they are currently
similar. There are already ideas on how these will diverge in the future
and while the duplication looks ugly at the moment, it is the option
that offers the highest flexibility.