Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that the field is aggregatable before attempting cardinality aggregation #53874

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Verify that the field is aggregatable before attempting cardinality aggregation #53874

merged 1 commit into from
Mar 23, 2020

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Mar 20, 2020 •
edited
Loading

This PR verifies that the field is aggregatable before attempting a cardinality aggregation on that field.
Due to that verification, the error message delivered to user is a bit more understandable.

Relates #53876

@przemekwitek przemekwitek force-pushed the classification_support_text_field branch 5 times, most recently from 2be6e4e to 907fc14 Compare March 23, 2020 10:42
@przemekwitek przemekwitek changed the title Remove "text" type from the set of supported categorical types Remove "text" type from the set of supported types for classification's dependent variable Mar 23, 2020
@przemekwitek przemekwitek force-pushed the classification_support_text_field branch 3 times, most recently from 58a275e to 871a5c7 Compare March 23, 2020 14:35
@przemekwitek przemekwitek force-pushed the classification_support_text_field branch from 871a5c7 to 7a2b3dd Compare March 23, 2020 14:38
@przemekwitek przemekwitek changed the title Remove "text" type from the set of supported types for classification's dependent variable Verify that the field is aggregatable before attempting cardinality aggregation Mar 23, 2020
@przemekwitek przemekwitek removed the WIP label Mar 23, 2020
@przemekwitek przemekwitek marked this pull request as ready for review March 23, 2020 14:43
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

benwtrent
benwtrent approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎸 🤘

@przemekwitek przemekwitek merged commit f783670 into elastic:master Mar 23, 2020
@przemekwitek przemekwitek deleted the classification_support_text_field branch March 23, 2020 17:38
@przemekwitek przemekwitek mentioned this pull request Mar 23, 2020
Merged
przemekwitek added a commit that referenced this pull request Mar 23, 2020
@przemekwitek
[7.x] Verify that the field is aggregatable before attempting cardina…
88c5d52 
…lity aggregation (#53874) (#54004)
@przemekwitek przemekwitek mentioned this pull request Mar 23, 2020
Closed
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
@lcawl lcawl mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou left review comments

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
>enhancement :ml Machine learning v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@przemekwitek @elasticmachine @benwtrent @dimitris-athanasiou @jakelandis