Use special XContent registry for node tool #54050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>bug
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
DaveCTurner
approved these changes
Mar 24, 2020
server/src/main/java/org/elasticsearch/cluster/coordination/ElasticsearchNodeCommand.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ElasticsearchNodeCommand.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ElasticsearchNodeCommand.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/ElasticsearchNodeCommand.java
Outdated
Show resolved
Hide resolved
ywelsch
added a commit
that referenced
this pull request
Mar 24, 2020
Fixes an issue where the elasticsearch-node command-line tools would not work correctly because PersistentTasksCustomMetaData contains named XContent from plugins. This PR makes it so that the parsing for all custom metadata is skipped, even if the core system would know how to handle it. Closes #53549
ywelsch
added a commit
that referenced
this pull request
Mar 24, 2020
Fixes an issue where the elasticsearch-node command-line tools would not work correctly because PersistentTasksCustomMetaData contains named XContent from plugins. This PR makes it so that the parsing for all custom metadata is skipped, even if the core system would know how to handle it. Closes #53549
yyff
pushed a commit
to yyff/elasticsearch
that referenced
this pull request
Apr 17, 2020
Fixes an issue where the elasticsearch-node command-line tools would not work correctly because PersistentTasksCustomMetaData contains named XContent from plugins. This PR makes it so that the parsing for all custom metadata is skipped, even if the core system would know how to handle it. Closes elastic#53549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the
elasticsearch-nodecommand-line tools would not work correctly becausePersistentTasksCustomMetaDatacontains named XContent from plugins. This PR makes it so that the parsing for all custom metadata is skipped, even if the core system would know how to handle it.Closes #53549